Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10797029: Enforce all the source files to be encoded in UTF-8. (Closed)

Created:
8 years, 5 months ago by M-A Ruel
Modified:
8 years, 5 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, pam+watch_chromium.org, Iain Merrick
Visibility:
Public.

Description

Enforce all the source files to be encoded in UTF-8. Many files used random encoding. All of them were in comments or unit test files that were not compiled. In any case, not using unicode everywhere complexify the tools so enforcing it makes presubmit checks much simpler. R=joi@chromium.org BUG= TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147480

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add README.chromium #

Total comments: 2

Patch Set 3 : vim #

Total comments: 2

Patch Set 4 : more readmes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -42 lines) Patch
M jingle/notifier/listener/push_notifications_subscribe_task.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/libxml/README.chromium View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libxml/src/entities.c View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/libxml/src/runtest.c View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/libxml/src/testapi.c View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/libxslt/README.chromium View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/libxslt/libxslt/xslt.c View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/mesa/MesaLib/src/mesa/drivers/dri/mach64/mach64_dd.c View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/mesa/MesaLib/src/mesa/drivers/dri/mach64/mach64_ioctl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/mesa/MesaLib/src/mesa/drivers/dri/mach64/mach64_lock.c View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/mesa/MesaLib/src/mesa/drivers/dri/mach64/mach64_native_vb.c View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/mesa/MesaLib/src/mesa/drivers/dri/mach64/mach64_native_vbtmp.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/mesa/MesaLib/src/mesa/drivers/dri/mach64/mach64_reg.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/mesa/MesaLib/src/mesa/drivers/dri/mach64/mach64_screen.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/mesa/MesaLib/src/mesa/drivers/dri/mach64/mach64_tex.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/mesa/MesaLib/src/mesa/drivers/dri/mach64/mach64_tex.c View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/mesa/MesaLib/src/mesa/drivers/dri/mach64/mach64_texstate.c View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/mesa/MesaLib/src/mesa/drivers/dri/mach64/mach64_tris.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/mesa/MesaLib/src/mesa/drivers/dri/mach64/mach64_tris.c View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/mesa/MesaLib/src/mesa/drivers/dri/mach64/mach64_vb.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/mesa/MesaLib/src/mesa/drivers/dri/mach64/mach64_vb.c View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/mesa/MesaLib/src/mesa/drivers/dri/mach64/mach64_vbtmp.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/mesa/MesaLib/src/mesa/x86/mmx_blendtmp.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/mesa/README.chromium View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/npapi/README.chromium View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/npapi/npspy/extern/plugin/npruntime.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/openmax/README.chromium View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M third_party/openmax/il/OMX_Other.h View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/talloc/libreplace/timegm.c View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/tcmalloc/README.chromium View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/tcmalloc/chromium/src/windows/ia32_modrm_map.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/tcmalloc/chromium/src/windows/ia32_opcode_map.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/tcmalloc/chromium/src/windows/mini_disassembler.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/tcmalloc/vendor/src/windows/ia32_modrm_map.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/tcmalloc/vendor/src/windows/ia32_opcode_map.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/tcmalloc/vendor/src/windows/mini_disassembler.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/memory_watcher/mini_disassembler.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
M-A Ruel
Choosing Joi as a reviewer since many of the \x92 bytes came from him. :) ...
8 years, 5 months ago (2012-07-19 14:35:43 UTC) #1
M-A Ruel
+Iain
8 years, 5 months ago (2012-07-19 14:44:37 UTC) #2
Ami GONE FROM CHROMIUM
drive-by https://r882-11cdd11fc1da-maruel-dot-chromiumcodereview.appspot.com/10797029/diff/1/third_party/openmax/il/OMX_Other.h File third_party/openmax/il/OMX_Other.h (right): https://r882-11cdd11fc1da-maruel-dot-chromiumcodereview.appspot.com/10797029/diff/1/third_party/openmax/il/OMX_Other.h#newcode93 third_party/openmax/il/OMX_Other.h:93: * OMX_IndexConfigTimeCurrentWallTime: query of the CC's current wall ...
8 years, 5 months ago (2012-07-19 15:14:00 UTC) #3
M-A Ruel
On 2012/07/19 15:14:00, Ami Fischman wrote: > third_party/openmax/README.chromium claims: > Local Modifications: > No Modifications ...
8 years, 5 months ago (2012-07-19 15:28:01 UTC) #4
Ami GONE FROM CHROMIUM
https://r882-11cdd11fc1da-maruel-dot-chromiumcodereview.appspot.com/10797029/diff/5001/third_party/openmax/README.chromium File third_party/openmax/README.chromium (right): https://r882-11cdd11fc1da-maruel-dot-chromiumcodereview.appspot.com/10797029/diff/5001/third_party/openmax/README.chromium#newcode14 third_party/openmax/README.chromium:14: Converted to utf-8 That's not a helpful comment to ...
8 years, 5 months ago (2012-07-19 15:36:28 UTC) #5
Jói
This change looks fine to me but agree it seems more useful to make it ...
8 years, 5 months ago (2012-07-19 15:42:00 UTC) #6
M-A Ruel
https://r882-11cdd11fc1da-maruel-dot-chromiumcodereview.appspot.com/10797029/diff/5001/third_party/openmax/README.chromium File third_party/openmax/README.chromium (right): https://r882-11cdd11fc1da-maruel-dot-chromiumcodereview.appspot.com/10797029/diff/5001/third_party/openmax/README.chromium#newcode14 third_party/openmax/README.chromium:14: Converted to utf-8 On 2012/07/19 15:36:29, Ami Fischman wrote: ...
8 years, 5 months ago (2012-07-19 15:49:18 UTC) #7
Ami GONE FROM CHROMIUM
LGTM % missing README updates. https://r882-11cdd11fc1da-maruel-dot-chromiumcodereview.appspot.com/10797029/diff/6007/third_party/libxslt/libxslt/xslt.c File third_party/libxslt/libxslt/xslt.c (right): https://r882-11cdd11fc1da-maruel-dot-chromiumcodereview.appspot.com/10797029/diff/6007/third_party/libxslt/libxslt/xslt.c#newcode5170 third_party/libxslt/libxslt/xslt.c:5170: * Don't use xsltGetQNameURI() ...
8 years, 5 months ago (2012-07-19 15:56:53 UTC) #8
M-A Ruel
8 years, 5 months ago (2012-07-19 15:59:52 UTC) #9 
On 2012/07/19 15:56:53, Ami Fischman wrote:
> LGTM % missing README updates.
> 
>
https://r882-11cdd11fc1da-maruel-dot-chromiumcodereview.appspot.com/10797029/...
> File third_party/libxslt/libxslt/xslt.c (right):
> 
>
https://r882-11cdd11fc1da-maruel-dot-chromiumcodereview.appspot.com/10797029/...
> third_party/libxslt/libxslt/xslt.c:5170: *  Don't use xsltGetQNameURI() as it
> cannot channel
> Needs README.chromium update
> 
>
https://r882-11cdd11fc1da-maruel-dot-chromiumcodereview.appspot.com/10797029/...
> File third_party/mesa/README.chromium (right):
> 
>
https://r882-11cdd11fc1da-maruel-dot-chromiumcodereview.appspot.com/10797029/...
> third_party/mesa/README.chromium:19: - Converted to utf-8
> why no vim command here?

Done both.

Powered by Google App Engine
This is Rietveld 408576698