[iOS] Clean deps and public_deps.

[iOS] Clean deps and public_deps.

Only use public_deps to forward public_configs or to make multiple
target appears as a single target (usually a group target).

Remove unused target //ios/public/provider/chrome/browser:provider_flags.

BUG=658242
Committed: https://crrev.com/20460d67f96c28ff59d2c97381068b40f31b6d39
Cr-Commit-Position: refs/heads/master@{#435300}

[sdefresne, 2016-11-30 14:38:38]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 14:38:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-11-30 14:40:52]

Description was changed from

==========
[iOS] Clean deps and public_deps.

Only use public_deps to forward public_configs or to make multiple
target appears as a single target (usually a group target).

Remove unused target //ios/public/provider/chrome/browser:provider_flags.

BUG=None
==========

to

==========
[iOS] Clean deps and public_deps.

Only use public_deps to forward public_configs or to make multiple
target appears as a single target (usually a group target).

Remove unused target //ios/public/provider/chrome/browser:provider_flags.

BUG=658242
==========

[sdefresne, 2016-11-30 14:40:52]

sdefresne@chromium.org changed reviewers:
+ rohitrao@chromium.org

[sdefresne, 2016-11-30 14:41:04]

Please take a look.

[commit-bot: I haz the power, 2016-11-30 14:46:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 14:46:17]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[sdefresne, 2016-11-30 14:49:03]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 14:49:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rohitrao (ping after 24h), 2016-11-30 14:55:51]

LGTM but I don't understand the rules for when public_deps are needed.

If you #include "something" from a header, should that go in public_deps?  If
not, is every target responsible for including the "something" dep individually,
even if they never directly use it?

[sdefresne, 2016-11-30 15:03:49]

On 2016/11/30 14:55:51, rohitrao wrote:
> LGTM but I don't understand the rules for when public_deps are needed.
> 
> If you #include "something" from a header, should that go in public_deps?  If
> not, is every target responsible for including the "something" dep
individually,
> even if they never directly use it?

If you explicitly #include a header from another target, you must have a
dependency on it. If you export a header that include a header from another
target, you *may* need to have a public_deps on that target. You only need to
have a public_deps if a simple deps does not work. This happens when the target
has a public_configs with settings that are required to properly use it
(generally include_dirs).

Another situation where you would use public_deps is when you want to have a
single public target composed of multiple internal targets (for example
//ios/chrome/app/strings that is a group depending on
//ios/chrome/app/strings:{ios_strings,ios_chromium_strings,ios_google_chrome_strings}).

Those rules are derived from the error you get when you run "gn check"

    It's usually best to depend directly on the destination target.
    In some cases, the destination target is considered a subcomponent
    of an intermediate target. In this case, the intermediate target
    should depend publicly on the destination to forward the ability
    to include headers.

[sdefresne, 2016-11-30 15:43:16]

The CQ bit was unchecked by sdefresne@chromium.org

[sdefresne, 2016-11-30 15:43:18]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2016-11-30 15:43:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 17:05:12]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480520598410340,
"parent_rev": "75ecf6ea144ba4c0d419b8be66ff0f9ad7d499f3", "commit_rev":
"18cf6870e7b347b1bc583f140d42d70e3123973e"}

[commit-bot: I haz the power, 2016-11-30 17:05:36]

Description was changed from

==========
[iOS] Clean deps and public_deps.

Only use public_deps to forward public_configs or to make multiple
target appears as a single target (usually a group target).

Remove unused target //ios/public/provider/chrome/browser:provider_flags.

BUG=658242
==========

to

==========
[iOS] Clean deps and public_deps.

Only use public_deps to forward public_configs or to make multiple
target appears as a single target (usually a group target).

Remove unused target //ios/public/provider/chrome/browser:provider_flags.

BUG=658242
==========

[commit-bot: I haz the power, 2016-11-30 17:05:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-30 17:08:01]

Description was changed from

==========
[iOS] Clean deps and public_deps.

Only use public_deps to forward public_configs or to make multiple
target appears as a single target (usually a group target).

Remove unused target //ios/public/provider/chrome/browser:provider_flags.

BUG=658242
==========

to

==========
[iOS] Clean deps and public_deps.

Only use public_deps to forward public_configs or to make multiple
target appears as a single target (usually a group target).

Remove unused target //ios/public/provider/chrome/browser:provider_flags.

BUG=658242

Committed: https://crrev.com/20460d67f96c28ff59d2c97381068b40f31b6d39
Cr-Commit-Position: refs/heads/master@{#435300}
==========

[commit-bot: I haz the power, 2016-11-30 17:08:02]

Patchset 2 (id:??) landed as
https://crrev.com/20460d67f96c28ff59d2c97381068b40f31b6d39
Cr-Commit-Position: refs/heads/master@{#435300}